fix race condition with TSCUtility.Platform::darwinCacheDirectories #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: TSCUtility.Platform::darwinCacheDirectories is not thread-safe, can cause race condition when accessing concurrently changes: wrap TSCUtility.Platform::darwinCacheDirectories with ThreadSafeArrayStore
tomerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
federicobucchi
approved these changes
Dec 27, 2020
|
hmm linker error, maybe CI is busted. @swift-ci please smoke test OS X Platform |
|
This looks good, but would it be better to fix TSC's method to be thread safe so other clients would benefit too? |
abertelrud
approved these changes
Jan 5, 2021
yes this is my plan |
|
@swift-ci please smoke test macOS Platform |
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: TSCUtility.Platform::darwinCacheDirectories is not thread-safe, can cause race condition when accessing concurrently
changes: wrap TSCUtility.Platform::darwinCacheDirectories with ThreadSafeArrayStore