Skip to content

Update CODEOWNERS #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Update CODEOWNERS #3181

merged 1 commit into from
Jan 10, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Jan 10, 2021

remove Ankit, add Tomer

remove Ankit, add Tomer
@abertelrud
Copy link
Contributor

@swift-ci please smoke test

@abertelrud
Copy link
Contributor

We’ll probably need to get this into the 5.4 branch before we can merge PRs such as #3177 with just your approval, but since I’m already listed as code owner, I can approve the cherrypick of this one to the 5.4 branch and then your approval for #3177 should be sufficient.

@abertelrud
Copy link
Contributor

abertelrud commented Jan 10, 2021

This looks good to me. @tomerd should we merge this to main, then I’ll approve a 5.4 cherry-pick branch and then that should allow merging of the other 5.4 PRs that already have your approval? (so that this technicality doesn't hold up merging changes that have been approved in principle)

@tomerd
Copy link
Contributor Author

tomerd commented Jan 10, 2021

@tomerd should we merge this to main, then I’ll approve a 5.4 cherry-pick branch and then that should allow merging of the other 5.4 PRs that already have your approval? (so that this technicality doesn't hold up merging changes that have been approved in principle)

yes

@tomerd tomerd merged commit f6f8de1 into main Jan 10, 2021
tomerd added a commit to tomerd/swift-package-manager that referenced this pull request Jan 10, 2021
remove Ankit, add Tomer
tomerd added a commit that referenced this pull request Jan 10, 2021
remove Ankit, add Tomer
@tomerd tomerd deleted the tomerd-patch-1 branch March 18, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants