[5.4] limit size of sqlite manifest cache (#3178) #3204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: sqlite manifest cache is now shared by default, controlling its max size is important changes: * introduce SQLiteManifestCache::Configuraiton allowing to set max database size * when database is full, truncate it. this is not refined, but since this is a cache it should be fine. * add tests including a couple of other tests for SQLiteManifestCache that were missing * adjust to latest tsc
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
tomerd
changed the title
abertelrud
approved these changes
Jan 19, 2021
neonichu
approved these changes
Jan 19, 2021
tomerd
changed the title
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring #3178 into 5.4