Revert "Package collections: improve search performance" #3212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1eb1342.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
|
@yim-lee are you proposing to revert due to the CentOS issue? Maybe the sqlite for those systems is not compiled with the options we need for FTS? @drexin may be able to help locate appropriate packages (or a solution) for those systems alternatively, we can try to have a dual solution where we leverage FTS where it exists |
|
Yes, because it will take me time to repro and verify a fix. |
tomerd
approved these changes
Jan 21, 2021
neonichu
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3108
It seems to be causing failures in these builds:
https://ci.swift.org/job/oss-swift-package-amazon-linux-2/1086
https://ci.swift.org/job/oss-swift-package-centos-7/536