PackageDescription: mark imports as implementation-only #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Glibc`/`Darwin`/`ucrt` imports are not used in the public interface of `PackageDescription`, so there is no need to expose them. This change hides the import statements from the generated `PackageDescription` module interface.
egorzhdan
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
|
seems reasonable to me. @abertelrud @compnerd ? |
federicobucchi
approved these changes
Jan 28, 2021
|
Looks good to me as well. I don't think these were intended to be exposed. Thanks @egorzhdan! |
abertelrud
approved these changes
Feb 1, 2021
|
Would be interested in @compnerd's opinion too. |
Ah, and of course, when they were added, I don't think implemenation-only existed yet. |
compnerd
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Symbols from
Glibc/Darwin/ucrtare not used in the public interface ofPackageDescription, so there is no need to expose them in the generated module interface.Modifications:
This change hides the import statements from the generated
PackageDescriptionmodule interface.It relies on swiftlang/swift#35575 (already merged).
Result:
After this change SourceKit returns a
PackageDescriptioninterface withoutimport Darwin.C/import Glibc/import ucrt.