fix potential race in PackageCollections.refreshCollections #3232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: CI crashes in PackageCollectsTest::testBrokenRefresh suggest a race condition in the code changes: * change ThreadSafeArrayStore::apend to return the current count in a thread safe manner * update the callsite to use the count returned from append instead of after the append -- which could be racy rdar://73884751
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 3, 2021
Motivation: `testHappyRefresh` crashed in https://ci.swift.org/job/oss-swift-package-centos-8/975 ``` Test Suite 'PackageCollectionsTests' started at 2021-03-02 22:01:52.483 Test Case 'PackageCollectionsTests.testHappyRefresh' started at 2021-03-02 22:01:52.483 Exited with signal code 11 ``` This is similar to swiftlang#3232 Modifications: Both `testHappyRefresh` and `testBrokenRefresh` call `listCollections` after `refreshCollections`, and part of the `listCollections` code where we read collection blobs from the database might be racy since we are not using `ThreadSafeArrayStore`.
yim-lee
added a commit
that referenced
this pull request
Mar 4, 2021
Motivation: `testHappyRefresh` crashed in https://ci.swift.org/job/oss-swift-package-centos-8/975 ``` Test Suite 'PackageCollectionsTests' started at 2021-03-02 22:01:52.483 Test Case 'PackageCollectionsTests.testHappyRefresh' started at 2021-03-02 22:01:52.483 Exited with signal code 11 ``` This is similar to #3232 Modifications: Both `testHappyRefresh` and `testBrokenRefresh` call `listCollections` after `refreshCollections`, and part of the `listCollections` code where we read collection blobs from the database might be racy since we are not using `ThreadSafeArrayStore`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: CI crashes in PackageCollectsTest::testBrokenRefresh suggest a race condition in the code
changes: