Fix BuildOperationBuildSystemDelegateHandler
#3249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got broken in swiftlang#3209 which was using `llbuildSwift` unconditionally. This is easy to miss, but in some environments we set `SWIFTPM_LLBUILD_FWK` and link against a pre-built framework which will only have the module `llbuild`. We should improve the testing here and build in both modes to avoid this kind of breakage in the future.
neonichu
requested review from
abertelrud,
friedbunny and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Feb 9, 2021
friedbunny
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken in #3209 which was using
llbuildSwiftunconditionally. This is easy to miss, but in some environments we setSWIFTPM_LLBUILD_FWKand link against a pre-built framework which will only have the modulellbuild.We should improve the testing here and build in both modes to avoid this kind of breakage in the future.