Skip to content

Updated tests for SE-0036 and SE-0066 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2016

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 7, 2016

SE-0066 has already been implemented in swift and currently swift-pm tests are currently failing.

The pull request for SE-0036 is pending, tests for it are failing without this update.

Both changes are backwards-compatible and do not require any further implementation in swift.

@ddunbar
Copy link
Contributor

ddunbar commented May 7, 2016

I don't see tests failing on TOT due to 0066, although I do see a bunch of warnings. However, this PR seems to have missed a few of those cases, for example:

swiftpm/Sources/POSIX/popen.swift:22:122: warning: single argument function types require parentheses
public func popen(_ arguments: [String], redirectStandardError: Bool = false, environment: [String: String] = [:], body: String -> Void) throws
                                                                                                                         ^~~~~~
                                                                                                                         (     )
Link POSIX
Compile Swift Module 'Utility' (14 sources)
Link PackageDescription
swiftpm/Sources/Utility/Verbosity.swift:92:122: warning: single argument function types require parentheses
public func popen(_ arguments: [String], redirectStandardError: Bool = false, environment: [String: String] = [:], body: String -> Void) throws {
                                                                                                                         ^~~~~~
                                                                                                                         (     )
swiftpm/Sources/Utility/Verbosity.swift:92:122: warning: single argument function types require parentheses
public func popen(_ arguments: [String], redirectStandardError: Bool = false, environment: [String: String] = [:], body: String -> Void) throws {
                                                                                                                         ^~~~~~
                                                                                                                         (     )
swiftpm/Sources/Utility/Verbosity.swift:92:122: warning: single argument function types require parentheses
public func popen(_ arguments: [String], redirectStandardError: Bool = false, environment: [String: String] = [:], body: String -> Void) throws {
                                                                                                                         ^~~~~~
                                                                                                                         (     )

@ddunbar
Copy link
Contributor

ddunbar commented May 7, 2016

@swift-ci please test and merge

@ddunbar
Copy link
Contributor

ddunbar commented May 7, 2016

Fixed the others in 3db9452.

@swift-ci swift-ci merged commit 8b98167 into swiftlang:master May 8, 2016
aciidgh pushed a commit to aciidgh/swift-package-manager that referenced this pull request Jan 11, 2019
[BuildSystem] Add discovered-dependencies-file support to CAPIExternalCommand
@ahoppen ahoppen deleted the tests-update branch November 8, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants