refactor http client #3255
Merged
refactor http client #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
|
Compilation error on Linux only? The PR looks good overall. |
tomerd
force-pushed
the
refactor/http-consolidaton
branch
3 times, most recently
from
bf190d2 to
c21a18a
Compare
motivation: * safer handling of large responses * prepare to consolidate Downloader from TSC and http client from Basics changes: * add progress support to HTTPclient::execute and URLSession based impl * add HTTPClientRequest::Options::maxResponseSize and logic to fail the request if response is too large * add authorization support to HTTPClientRequest::Options and HTTPClient::Configuration * refactor call-sites to use new ways * add and adopt tests
tomerd
force-pushed
the
refactor/http-consolidaton
branch
from
c21a18a to
d3500ba
Compare
tomerd
commented
Feb 11, 2021
| @@ -8,28 +16,84 @@ import struct TSCUtility.Versioning | |||
| import FoundationNetworking | |||
| #endif | |||
|
|
|||
| public struct URLSessionHTTPClient: HTTPClientProtocol { | |||
| public final class URLSessionHTTPClient: NSObject, HTTPClientProtocol { | |||
tomerd
commented
Feb 11, 2021
| self.underlying( | ||
| request, | ||
| { received, expected in | ||
| if let max = request.options.maximumResponseSizeInBytes { |
There was a problem hiding this comment.
@yim-lee this is to better support "maximumResponseSizeInBytes" at the response buffering time
tomerd
commented
Feb 11, 2021
| @@ -275,15 +275,48 @@ class JSONPackageCollectionProviderTests: XCTestCase { | |||
| }) | |||
| } | |||
|
|
|||
| func testExceedsDownloadSizeLimitProgress() throws { | |||
|
@swift-ci please smoke test |
yea seems like some of the nicer APIs are not supported on Linux, so had to do it the hard way... PR updated |
neonichu
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: prepare to consolidate downloader from TSC and http client from Basics
changes: