Prevent manifest load errors from causing SwiftPM to display "fatalError" in CLI #3262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror" in CLI Looks like `Diagnostics.fatalError` is used to throw errors when appropriate diagnostics have already been emitted and the only goal is to quickly return to the caller. This is documented in TSCUtility. Future cleanup should avoid this special behavior. rdar://74263826
abertelrud
requested review from
friedbunny,
neonichu and
tomerd
as code owners
|
I have been looking for how to add a better unit test for this that than a test fixture. So far I have not been able to trigger it from tests. |
|
@swift-ci please smoke test |
tomerd
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
mainthread cherry-pick of #3261Looks like
Diagnostics.fatalErroris used to throw errors when appropriate diagnostics have already been emitted and the only goal is to quickly return to the caller. This is documented in TSCUtility.Future cleanup should avoid this special behavior.
Motivation:
This prevents an ugly extra line of output
Changes:
It prevents
Diagnostics.fatalErrorfrom being added to the diagnostics engine, in a way that's similar to how it is done in some other places.rdar://74263826