Use executableTarget in generated new executable packages
#3263
Conversation
egorzhdan
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
|
Thanks for the PR! This is a great change in the log run, but because 5.4 is very new, does it make sense for new packages to require it? New packages should still build without warning since they currently specify 5.3 manually. |
|
I think in previous releases, we have updated the template to use the latest tools-version. |
this makes sense to me, ideally it's pinned to "current" and does not require manual changes and the unit tests catch if there are any issues with a newly minted packages. |
|
Thanks for the feedback! The recent releases like 5.3/5.2/5.1 indeed use the latest available tools-version, and this PR targets the 6.0 branch, so I thought it would be fine to increase it to 5.4. |
That makes sense to me — I didn't realize that there was precedent here. |
Sources/Workspace/InitPackage.swift
Outdated
| @@ -15,7 +15,7 @@ import PackageModel | |||
| /// Create an initial template package. | |||
| public final class InitPackage { | |||
| /// The tool version to be used for new packages. | |||
| public static let newPackageToolsVersion = ToolsVersion(version: "5.3.0") | |||
| public static let newPackageToolsVersion = ToolsVersion(version: "5.4.0") | |||
There was a problem hiding this comment.
given the other comments can we change this to the "current version", .i.e SwiftVersion.currentVersion and confirm we have unit tests to make sure it never broken (I believe we already do)
There was a problem hiding this comment.
Fixed. Yes, there is already a test that ensures the generated packages are buildable & contain the // swift-tools-version comment (WorkspaceTests/InitTests.swift)
egorzhdan
force-pushed
the
init-exec-targets
branch
from
33b9166 to
88f5dcb
Compare
|
@swift-ci please smoke test |
|
macOS CI broken due to swift-driver cc @artemcm |
|
@swift-ci please smoke test macOS |
Motivation:
Newly generated executable packages currently use
.target(...)API for declaring the executable target, which seems to be deprecated since 5.4.Modifications:
swift-tools-versionfor new packages to 5.4.targetcall with.executableTargetfor new executable packagesResult:
After this change
swift package init --type executablegenerates a package which declares the executable target via the new.executableTarget(...)API.