Skip to content

[Collections] Export PackageCollectionsSigning as library #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

yim-lee
Copy link
Contributor

@yim-lee yim-lee commented Feb 14, 2021

We will add signing to the set of collections tools, and for that we'd need PackageCollectionsSigning.

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neonichu may have opinions on this

@tomerd tomerd added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Feb 16, 2021
yim-lee added a commit to yim-lee/swift-package-collection-generator that referenced this pull request Feb 17, 2021
This is **experimental**!!!

Depends on swiftlang/swift-package-manager#3275
@yim-lee yim-lee changed the title [DNM][Collections] Export PackageCollectionsSigning as library [Collections] Export PackageCollectionsSigning as library Feb 19, 2021
We will add signing to [the set of collections tools](https://github.com/apple/swift-package-collection-generator), and for that we'd need `PackageCollectionsSigning`.
@yim-lee
Copy link
Contributor Author

yim-lee commented Feb 19, 2021

@swift-ci please smoke test

@yim-lee yim-lee merged commit de3e01f into swiftlang:main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants