[Collections] Add skip signature check option to 'add' #3291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: On non-Apple platforms since there are no trusted root certificates by default, signature checks will most certainly fail. To help people get started more quickly, and to offer people a way to opt-out, we will add a `--skip-signature-check` flag to the `add` collection command. User's selection is persisted to collection sources config such that `refresh` would honor it as well. Modifications: - Add `skipSignatureCheck` to `CollectionSource` - Add `--skip-signature-check` to CLI - Add `isVerified` to `Collection.SignatureData`. It is `false` when `skipSignatureCheck == true`. - Update logic in `JSONPackageCollectionProvider` to honor `skipSignatureCheck` - Update CLI to handle `cannotVerifySignature` error
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
On non-Apple platforms since there are no trusted root certificates by default, signature checks will most certainly fail. To help people get started more quickly, and to offer people a way to opt-out, we will add a
--skip-signature-checkflag to theaddcollection command. User's selection is persisted to collection sources config such thatrefreshwould honor it as well.Modifications:
skipSignatureChecktoCollectionSource--skip-signature-checkto CLIisVerifiedtoCollection.SignatureData. It isfalsewhenskipSignatureCheck == true.JSONPackageCollectionProviderto honorskipSignatureCheckcannotVerifySignatureerror