[Collections] Check for collections that are required to be signed #3297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Feb 21, 2021
tomerd
added
the
ready
Motivation: If a collection source has an entry in the certificate pinning configuration that it must be signed. Currently we are not checking for this. Modifications: Update `JSONPackageCollectionProvider` to check that if a collection is unsigned, then it shouldn't have an entry in the certificate pinning configuration. Otherwise, throw `missingSignature` error which cannot be bypassed.
yim-lee
force-pushed
the
signing-required
branch
from
d8aedc6 to
6e92e71
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a collection source has an entry in the certificate pinning configuration that it must be signed. Currently we are not checking for this.
Modifications:
Update
JSONPackageCollectionProviderto check that if a collection is unsigned, then it shouldn't have an entry in the certificate pinning configuration. Otherwise, throwmissingSignatureerror which cannot be bypassed.