[Collections] refreshCollection should have correct source config #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `refreshCollection` relies on `CollectionSource` argument to provide the correct source config, but it should: 1. Check that the source exists in the config 2. Read latest source config from storage Modifications: Update `refreshCollection` to check that the given source exists in config file before actually doing a refresh. Also make sure that `Collection`'s `source` is current before returning it.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Feb 27, 2021
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refreshCollectionrelies onCollectionSourceargument to provide the correct source config, but it should:Modifications:
Update
refreshCollectionto check that the given source exists in config file before actually doing a refresh. Also make sure thatCollection'ssourceis current before returning it.