Skip to content

make download test utilities thread-safe #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Mar 5, 2021

motivation: fix flaky tests

changes:

  • make MockArchiver thread safe + refactor for better readability
  • make few WorkspaceTests that monitor downloads thread-safe
  • refactor MockHashAlgorithm for for better readability (same change as MockArchiver)

rdar://75060297

motivation: fix flaky tests

changes:
* make MockArchiver thread safe + refactor for better readability
* make few WorkspaceTests that monitor downloads thread-safe
* refactor MockHashAlgorithm for for better readability (same change as MockArchiver)

rdar://75060297
@tomerd
Copy link
Contributor Author

tomerd commented Mar 5, 2021

@swift-ci please smoke test

@tomerd tomerd added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Mar 5, 2021
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerd tomerd merged commit d1ef837 into swiftlang:main Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants