Skip to content

stop testArchiveSource from writing files to package root #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Mar 6, 2021

motivation the test "testArchiveSource" has been writing a file to the project's root when invoked from the command line

changes: change the test to use a temporary directory instead of current working directory

motivation the test "testArchiveSource" has been writing a file to the project's root when invoked from the command line

changes: change the test to use a temporary directory instead of current working directory
@tomerd
Copy link
Contributor Author

tomerd commented Mar 6, 2021

@swift-ci please smoke test

@tomerd tomerd added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Mar 6, 2021
@tomerd tomerd changed the title stop testArchiveSource from writing files to pacakge root stop testArchiveSource from writing files to package root Mar 6, 2021
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'd noticed this file but not yet looking into where it came from.

@abertelrud abertelrud merged commit 4ba446b into swiftlang:main Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants