-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Pass through shell script build phase environment and working directory for build tool commands #3333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through shell script build phase environment and working directory for build tool commands #3333
Conversation
@swift-ci please smoke test |
Note: This should only be merged after #3332 since every PR is a squash now but the changes should be separate in the revision history. |
Ok, that's disappointing. That will require an |
Oh right, it's because it uses |
It's a little annoying — supporting initial working directory is mostly for completeness. Build tools should in general take full paths and not rely on a custom working directory. We'll need to decide whether supporting relative paths (arguably an anti-pattern) is important enough to put in workarounds, or whether it's better to leave it out and just have the plugin form the path. Environment is the important one to support. |
I think what I'm going to do here is to remove the working directory functionality for now. It's not so important as to steal time from other things (such as better diagnostics, etc), and it is straightforward to add later. |
@swift-ci please smoke test linux |
…t build phase environment and working directory for build tool commands. Support for working directories is temporarily marked as unavailable since llbuild doesn't currently support it on platforms other than Darwin. This restriction will be removed when llbuild starts to support it. rdar://74663489
f009b72
to
7ee3551
Compare
Updated to mark the ability to set a working directory as not yet available, and updated unit test. |
@swift-ci please smoke test |
Use the new LLBuildManifestWriter support to pass through shell script build phase environment and working directory for build tool commands.
This PR builds on #3332
Motivation:
Plugin-created commands should be able to specify environment and initial working directory for those commands.
Modifications:
rdar://74663489