Add better unit test failure diagnostics for when basic SwiftPM commands fail #3334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds fail The motivation here is to find and fix a unit test failure that only seems to happen in CI.
abertelrud
commented
Mar 8, 2021
| @@ -34,15 +34,18 @@ final class PackageToolTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testUsage() throws { | |||
| XCTAssert(try execute(["--help"]).stdout.contains("USAGE: swift package")) | |||
| let stdout = try execute(["-help"]).stdout | |||
There was a problem hiding this comment.
The use of a single dash here is intentional so that we test both --help and -help. The build tool test already did this, the others did not.
|
@swift-ci please smoke test |
neonichu
approved these changes
Mar 8, 2021
tomerd
approved these changes
Mar 8, 2021
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the stdout that was received to the test failure, so we can know what the problem is. This is good in general, since it's hard to diagnose these failures without seeing the output.
The motivation here is to find and fix a unit test failure that only seems to happen in CI.