Skip to content

Fix experimental-api-diff command and add a test #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Mar 14, 2021

This fixes swift package experimental-api-diff, which doesn't need or accept library search path arguments. I also added a small test to avoid regressions in the short term. The motivation here is to begin working towards semantic versioning suggestions for packages when tagging a release.

@owenv
Copy link
Contributor Author

owenv commented Mar 14, 2021

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Mar 14, 2021

Hmm, I might need to skip the test in some environments - Xcode toolchains presumably won't have swift-api-digester until sometime after swiftlang/swift#36381 is merged

@owenv owenv force-pushed the fix-api-digester-integration branch from 0d7e47c to ab90dce Compare March 14, 2021 20:51
@owenv
Copy link
Contributor Author

owenv commented Mar 14, 2021

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Mar 14, 2021

14:35:25 [504/850] Testing CommandsTests.PackageToolTests/testAPIDiff

Looks like in the full smoke test config on macOS we are able to run the test

@owenv owenv reopened this Mar 24, 2021
@owenv
Copy link
Contributor Author

owenv commented Mar 24, 2021

I added a second commit here which:

  • Loads the modules in the current version of the package directly instead of dumping JSON and comparing that against the baseline
  • Removes the invert-baseline option since there are better ways of detecting semver minor changes and it will be difficult to support under the new model

@owenv
Copy link
Contributor Author

owenv commented Mar 24, 2021

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Mar 24, 2021

@swift-ci please test self hosted Linux

@owenv
Copy link
Contributor Author

owenv commented Mar 24, 2021

@swift-ci please smoke test Linux

@owenv
Copy link
Contributor Author

owenv commented Apr 17, 2021

@swift-ci please smoke test

@tomerd
Copy link
Contributor

tomerd commented Apr 19, 2021

thanks for your patience @owenv. 5.5 was just branched this weekend so we are finally ready to take this, @neonichu can work with you to land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants