[Collections] Adjust cert verify date in tests #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Tests in `PackageCollectionsSigningTests` that involve `Test_ec.cer` are failing. See swiftlang#3393. I think this is a timezone-related issue. `Test_ec.cer` is valid from November 15, 2020 10:45:20am PST for a year. In the tests we manipulate the timestamp at which the cert validation is done so we don't have to regenerate new test certs and so we can test for different scenarios. That timestamp is set to November 16, 2020 midnight, and depending on where the tests are run, it might potentially mean a time before `Test_ec.cer` is valid and that's why we see "certificate is not yet valid" error. Note that this doesn't happen with tests that use `Test_rsa.cer` since the certificate is valid from November 8, 2020. Modification: Change verify date to November 18, 2020, which should give us more than enough buffer for various timezones.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Apr 13, 2021
tomerd
reviewed
Apr 13, 2021
|
@swift-ci please smoke test |
|
I applied this patch and it fixed those three tests on Android, the different time zone was definitely the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Tests in
PackageCollectionsSigningTeststhat involveTest_ec.cerare failing. See #3393.I think this is a timezone-related issue.
Test_ec.ceris valid from November 15, 2020 10:45:20am PST for a year. In the tests we manipulate the timestamp at which the cert validation is done so we don't have to regenerate new test certs and so we can test for different scenarios. That timestamp is set to November 16, 2020 midnight, and depending on where the tests are run, it might potentially mean a time beforeTest_ec.ceris valid and that's why we see "certificate is not yet valid" error. Note that this doesn't happen with tests that useTest_rsa.cersince the certificate is valid from November 8, 2020.Modification:
Change verify date to November 18, 2020, which should give us more than enough buffer for various timezones.