Use implementation only import of Foundation in PackagePlugin #3408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… recently been done for manifests, and remove an extraneous leftover import
abertelrud
requested review from
friedbunny,
neonichu and
tomerd
as code owners
abertelrud
added
the
ready
|
@swift-ci please smoke test |
tomerd
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #3404 but for PackagePlugin.
Motivation:
As with PackageDescription, PackagePlugin should not have an interface dependency on Foundation. There is no specific current problem but reducing the dependencies here is cleaner.
Modifications:
Convert one import of Foundation to implementation-only (we need it for decoding the JSON coming from SwiftPM and for encoding the JSON sent to SwiftPM).
Remove another import of Foundation altogether; it was only left over from code that has since been removed.