[Collections] Fix flakey tests #3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some of the tests generate random HTTP status code to simulate bad collection URLs, but recent code changes distinguish status `404` from others and return a `notFound` error instead of `unavailable`. This causes tests to fail randomly. Modification: Change range of random generated status code to start from 500 such that `404` is excluded.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Apr 16, 2021
abertelrud
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some of the tests generate random HTTP status code to simulate bad collection URLs, but recent code changes distinguish status
404from others and return anotFounderror instead ofunavailable. This causes tests to fail randomly.Modification:
Change range of random generated status code to start from 500 such that
404is excluded.