[Collections] Better handling of spaces in collection file path #3412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Try adding a local package collection file with space(s) in the filename and it would result in error "Error: Invalid argument 'collectionUrl'". Modifications: In case `URL(string:)` fails, try `URL(fileURLWithPath:)` if the path starts with `file://`. This initializer escapes whitespaces appropriately. rdar://76732268
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Apr 18, 2021
|
@yim-lee make sure to create a matching PR for release/5.5 branch as well once merged |
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Apr 20, 2021
…tlang#3412) Motivation: Try adding a local package collection file with space(s) in the filename and it would result in error "Error: Invalid argument 'collectionUrl'". Modifications: In case `URL(string:)` fails, try `URL(fileURLWithPath:)` if the path starts with `file://`. This initializer escapes whitespaces appropriately. rdar://76732268
yim-lee
added a commit
that referenced
this pull request
Apr 22, 2021
… (#3419) Motivation: Try adding a local package collection file with space(s) in the filename and it would result in error "Error: Invalid argument 'collectionUrl'". Modifications: In case `URL(string:)` fails, try `URL(fileURLWithPath:)` if the path starts with `file://`. This initializer escapes whitespaces appropriately. rdar://76732268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Try adding a local package collection file with space(s) in the filename and it would result in error "Error: Invalid argument 'collectionUrl'".
Modifications:
In case
URL(string:)fails, tryURL(fileURLWithPath:)if the path starts withfile://. This initializer escapes whitespaces appropriately.rdar://76732268