-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[5.4] Enable symlink support explicitly #3417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
motivation: enable git symlink support for Windows changes: pass core.symlinks=true to git clone operations
thanks for opening this @stevapple, we will keep an eye out for if/when we do a 5.4 dot release |
@swift-ci please smoke test |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stevapple to get this into 5.4 sooner, can you make this change windows only (i.e. behind an #if)? this will allow it to go out sooner in a linux/windows only dot release |
@tomerd Though the initial purpose is for Windows, I suppose that this change is also useful for Linux and Darwin machines where the user unexpectedly disabled symlink support systemwide. |
@stevapple correct, which is why we have merged the |
@swift-ci please test |
Enable symlink support explicitly
This is a cherry-pick of commit 5f80bd7 from
main
.Motivation:
enable git symlink support for Windows
Modifications:
pass core.symlinks=true to git clone operations
Result:
repositories cloned by SwiftPM will have
core.symlinks
set totrue