Skip to content

[5.4] Enable symlink support explicitly #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2021

Conversation

stevapple
Copy link
Contributor

Enable symlink support explicitly

This is a cherry-pick of commit 5f80bd7 from main.

Motivation:

enable git symlink support for Windows

Modifications:

pass core.symlinks=true to git clone operations

Result:

repositories cloned by SwiftPM will have core.symlinks set to true

motivation: enable git symlink support for Windows

changes: pass core.symlinks=true to git clone operations
@tomerd
Copy link
Contributor

tomerd commented Apr 20, 2021

thanks for opening this @stevapple, we will keep an eye out for if/when we do a 5.4 dot release

@tomerd
Copy link
Contributor

tomerd commented Apr 20, 2021

@swift-ci please smoke test

@tomerd
Copy link
Contributor

tomerd commented Apr 20, 2021

@swift-ci test

@tomerd tomerd self-assigned this May 4, 2021
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerd
Copy link
Contributor

tomerd commented May 10, 2021

@stevapple to get this into 5.4 sooner, can you make this change windows only (i.e. behind an #if)? this will allow it to go out sooner in a linux/windows only dot release

@stevapple
Copy link
Contributor Author

@tomerd Though the initial purpose is for Windows, I suppose that this change is also useful for Linux and Darwin machines where the user unexpectedly disabled symlink support systemwide.

@tomerd
Copy link
Contributor

tomerd commented May 11, 2021

@tomerd Though the initial purpose is for Windows, I suppose that this change is also useful for Linux and Darwin machines where the user unexpectedly disabled symlink support systemwide.

@stevapple correct, which is why we have merged the main PR without such conditionals. For 5.4 tho, if we want to get this sooner on a non-darwin patch release, we should conditionalize it, or if you prefer to wait until (and if) there is a cross platform patch release that is okay with me too

@tomerd
Copy link
Contributor

tomerd commented May 11, 2021

@swift-ci please test

@tkremenek tkremenek merged commit 2d1e8e8 into swiftlang:release/5.4 May 12, 2021
@stevapple stevapple deleted the release/5.4 branch May 12, 2021 12:23
stevapple added a commit to stevapple/swift-package-manager that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants