Handle both SwiftArgParser 0.3.x and 0.4.x output. #3418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://75172724 (cherry picked from commit a408582)
shahmishal
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
shahmishal
changed the title
|
@swift-ci test |
tomerd
approved these changes
Apr 20, 2021
abertelrud
approved these changes
Apr 20, 2021
|
@shahmishal is this ready to be merged? also note we would need a corresponding PR for release/5.5 branch if this needs to make it into 5.5 |
|
@tomerd I thought this was merged before we branched for release/5.5 |
|
@tomerd I thought this was merged before we branched for release/5.5 oh sorry, you are correct, I misread the target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking this change in release/5.4 to unblock Apple Silicon bot.