Skip to content

make test discovery generation output predictable #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Apr 23, 2021

motivation: predictable output will prevent exessive compiles

changes: sort keys before iterating on them

motivation: predictable output will prevent exessive compiles

changes: sort keys before iteratig on them
@tomerd
Copy link
Contributor Author

tomerd commented Apr 23, 2021

@swift-ci please smoke test

@tomerd tomerd added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Apr 23, 2021
@tomerd tomerd changed the title make test generation output predictable make test discovery generation output predictable Apr 23, 2021
@tomerd tomerd self-assigned this Apr 23, 2021
@tomerd
Copy link
Contributor Author

tomerd commented Apr 23, 2021

@swift-ci please smoke test

Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tomerd tomerd merged commit 72de2f5 into swiftlang:main Apr 24, 2021
tomerd added a commit to tomerd/swift-package-manager that referenced this pull request Apr 24, 2021
motivation: predictable output will prevent exessive compiles

changes: sort keys before iterating on them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants