[Collections] Auth tokens need to be mutable #3443
Conversation
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
| @@ -67,6 +67,14 @@ public struct PackageCollections: PackageCollectionsProtocol { | |||
| } | |||
| } | |||
|
|
|||
| public mutating func updateAuthTokens(_ authTokens: [AuthTokenType: String]?) { | |||
There was a problem hiding this comment.
Not my favorite approach. Open to other options. I don't think the API should be added to PackageCollectionsProtocol though.
There was a problem hiding this comment.
what about a setter for either authTokens or making configuration public?
There was a problem hiding this comment.
also another approach is to define Configuration::authToken to take a function that is called to retrieve the auth values
var authTokens = () -> [AuthTokenType: String]?
There was a problem hiding this comment.
also another approach is to define Configuration::authToken to take a function
I like this. Thanks. Changed impl to this instead. bb67334
There was a problem hiding this comment.
The approach in bb67334 is a breaking change though, so my original approach might be safer... 🤔
There was a problem hiding this comment.
I think its okay to break at this point if we think its the right API, we just need to coordinate landing it cc @neonichu
yim-lee
force-pushed
the
mutate-auth-tokens
branch
from
495cf4b to
bb67334
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
yim-lee
force-pushed
the
mutate-auth-tokens
branch
from
bb67334 to
c27410e
Compare
|
Rebased. @swift-ci please smoke test. |
* [Collections] Auth tokens need to be mutable rdar://77095793 * Change authTokens to be a function instead
* [Collections] Auth tokens need to be mutable rdar://77095793 * Change authTokens to be a function instead
rdar://77095793