fix package.resolved interplay with mirrors #3447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: mirror urls leak today to package.resolved changes: * add storage for "original urls" in the pins store * pass the mirors to the pins file handler * transform the url when encoding and decoding the pins store such that the package.resolved file contains the non-mirrored URL but SwiftPM internals work witht mirrored ones * adjust call-sites * add and adjust tests rdar://52529014 rdar://52529011
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
|
cc @weissi |
|
PR failing on driver issues cc @artemcm |
|
Yaaay, thanks. These are also known as |
|
@swift-ci please smoke test macOS |
neonichu
approved these changes
Apr 27, 2021
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Apr 27, 2021
motivation: mirror urls leak today to package.resolved changes: * add storage for "original urls" in the pins store * pass the mirors to the pins file handler * transform the url when encoding and decoding the pins store such that the package.resolved file contains the non-mirrored URL but SwiftPM internals work witht mirrored ones * adjust call-sites * add and adjust tests rdar://52529014 rdar://52529011
tomerd
added a commit
that referenced
this pull request
Apr 28, 2021
motivation: mirror urls leak today to package.resolved changes: * add storage for "original urls" in the pins store * pass the mirors to the pins file handler * transform the url when encoding and decoding the pins store such that the package.resolved file contains the non-mirrored URL but SwiftPM internals work witht mirrored ones * adjust call-sites * add and adjust tests rdar://52529014 rdar://52529011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: mirror urls leak today to package.resolved
changes:
rdar://52529014
rdar://52529011