Fix new package XCTest file formatting and include throws keyword #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Fix formatting of the XCTest source file in newly `init`'ed packages, and include the `throws` keyword on the example XCTest method as a convenience to users and to promote use of throwing test methods in XCTests. Changes: - Fix a bug in the formatting of XCTest source files in `InitPackage`, where the closing `"""` string terminator was outdented one level too far, which resulted in the file contents being indented unnecessarily. - Include the `throws` keyword on `func testExample()` in the new Library type package template. - Modify an existing test to validate these improvements. rdar://77209458 rdar://77209464
stmontgomery
requested review from
neonichu,
tomerd,
briancroom,
aciidgh and
abertelrud
|
@swift-ci please test |
|
@swift-ci please smoke test |
briancroom
approved these changes
Apr 27, 2021
|
Looks like there's something broken in swift-driver?
cc @artemcm |
|
@swift-ci please smoke test macOS platform |
|
Sorry, this was due to compiler version mismatch between swift-driver CI and self-hosted SwiftPM CI. |
|
@stmontgomery thanks for this! please note we would need another cherry-pick PR into release/5.5 if you want to include this in 5.5 |
tomerd
approved these changes
Apr 27, 2021
stmontgomery
added a commit
to stmontgomery/swift-package-manager
that referenced
this pull request
Apr 27, 2021
…iftlang#3448) Motivation: Fix formatting of the XCTest source file in newly `init`'ed packages, and include the `throws` keyword on the example XCTest method as a convenience to users and to promote use of throwing test methods in XCTests. Changes: - Fix a bug in the formatting of XCTest source files in `InitPackage`, where the closing `"""` string terminator was outdented one level too far, which resulted in the file contents being indented unnecessarily. - Include the `throws` keyword on `func testExample()` in the new Library type package template. - Modify an existing test to validate these improvements. rdar://77209458 rdar://77209464
stmontgomery
added a commit
that referenced
this pull request
Apr 27, 2021
) (#3449) Motivation: Fix formatting of the XCTest source file in newly `init`'ed packages, and include the `throws` keyword on the example XCTest method as a convenience to users and to promote use of throwing test methods in XCTests. Changes: - Fix a bug in the formatting of XCTest source files in `InitPackage`, where the closing `"""` string terminator was outdented one level too far, which resulted in the file contents being indented unnecessarily. - Include the `throws` keyword on `func testExample()` in the new Library type package template. - Modify an existing test to validate these improvements. rdar://77209458 rdar://77209464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Fix formatting of the XCTest source file in newly
init'ed library packages, and include thethrowskeyword on the example XCTest method as a convenience to users and to promote use of throwingXCTest methods.
Changes:
InitPackage, where the closing"""stringterminator was outdented one level too far, which resulted in the file contents being indented unnecessarily.
throwskeyword onfunc testExample()in the new Library type package template.rdar://77209458
rdar://77209464