enable netrc on non-darwin platforms #3466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: * netrc functionality is useful on all platforms * underlying functionality is avaialbe via swiftlang/swift-tools-support-core#210 changes: * remove platforms restructions where appropriate * add test fixute that actually exercises the netrc parsing logic * adjust tests to run on all platforms
|
related to swiftlang/swift-tools-support-core#210 |
tomerd
commented
May 4, 2021
| #else | ||
| diagnostics.emit(error: "'--netrc-file' option is only supported on macOS >=10.13") | ||
| #endif | ||
| } |
There was a problem hiding this comment.
this is not meaningful any longer since SwiftPM is >= 10.15 and its supported on other platforms
tomerd
commented
May 4, 2021
| #if os(macOS) // Netrc feature currently only supported on macOS | ||
| authProvider = try? Netrc.load(fromFileAtPath: netrcFilePath).get() | ||
| #endif | ||
| // FIXME: should this handle the error more gracefully? |
There was a problem hiding this comment.
@neonichu do you know why the error is ignored here? topic for different PR, but curios
tomerd
commented
May 4, 2021
| @@ -47,89 +47,50 @@ final class PackageToolTests: XCTestCase { | |||
| let stdout = try execute(["--version"]).stdout | |||
| XCTAssert(stdout.contains("Swift Package Manager"), "got stdout:\n" + stdout) | |||
| } | |||
|
|
|||
| func testNetrcSupportedOS() throws { | |||
There was a problem hiding this comment.
this is not meaningful any longer since SwiftPM is >= 10.15 and its supported on other platforms
tomerd
commented
May 4, 2021
| try execute(["--netrc-file", netrcPath.pathString, "resolve"], packagePath: packageRoot) | ||
| XCTAssert(true) | ||
|
|
||
| fixture(name: "DependencyResolution/External/XCFramework") { packageRoot in |
There was a problem hiding this comment.
new fixtures that actually uses netrc :D
|
@swift-ci please smoke test |
tomerd
added
the
ready
abertelrud
approved these changes
May 4, 2021
bitjammer
pushed a commit
to bitjammer/swift-package-manager
that referenced
this pull request
Jul 23, 2021
motivation: * netrc functionality is useful on all platforms * underlying functionality is avaialbe via swiftlang/swift-tools-support-core#210 changes: * remove platforms restructions where appropriate * add test fixute that actually exercises the netrc parsing logic * adjust tests to run on all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation:
changes: