[Collection] Optimize collection fetch in search methods #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: All the search methods in `SQLitePackageCollectionsStorage` start by fetching a subset or all of the collections from database. This is because prior to using FTS, search was done directly on the `Collection` instances. In case of FTS, we can optimize things by: 1. Fetching collections from the database iff there are matches. i.e., return `NotFoundError` or empty result early 2. Fetching only collections where matches are found Modifications: Rearrange logic in search methods to do the optimizations described above. Related to rdar://77873780
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
yim-lee
commented
May 12, 2021
| let packageQuery = "SELECT collection_id_blob_base64, repository_url FROM \(Self.packagesFTSName) WHERE \(Self.packagesFTSName) MATCH ?;" | ||
| try self.executeStatement(packageQuery) { statement in | ||
| try statement.bind([.string(query)]) | ||
| if self.useSearchIndices.get() ?? false { |
There was a problem hiding this comment.
The diff is hard to read, but the changes in each method follow the same pattern: if self.useSearchIndices == true, call self.list(identifiers: identifiers) to fetch collections after we perform the search. This allows us to only fetch the collections we absolutely need.
tomerd
approved these changes
May 12, 2021
bitjammer
pushed a commit
to bitjammer/swift-package-manager
that referenced
this pull request
Jul 23, 2021
) Motivation: All the search methods in `SQLitePackageCollectionsStorage` start by fetching a subset or all of the collections from database. This is because prior to using FTS, search was done directly on the `Collection` instances. In case of FTS, we can optimize things by: 1. Fetching collections from the database iff there are matches. i.e., return `NotFoundError` or empty result early 2. Fetching only collections where matches are found Modifications: Rearrange logic in search methods to do the optimizations described above. Related to rdar://77873780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
All the search methods in
SQLitePackageCollectionsStoragestart by fetching a subset or all of the collections from database. This is because prior to using FTS, search was done directly on theCollectioninstances. In case of FTS, we can optimize things by:NotFoundErroror empty result earlyModifications:
Rearrange logic in search methods to do the optimizations described above.
Related to rdar://77873780