[Collections] Support 'v' prefix in version #3495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
May 13, 2021
tomerd
approved these changes
May 13, 2021
neonichu
approved these changes
May 13, 2021
|
@swift-ci please smoke test |
|
Hmm test failure doesn't seem to be related to this PR but got the same failure twice already: @swift-ci please smoke test Linux |
|
CI failure reproducible with Updating test: #3496 |
|
@swift-ci please smoke test self hosted Linux |
|
@swift-ci please smoke test self hosted |
Motivation: Package versions with 'v' prefix (e.g., `v1.0.0`) in a collection are dropped because they are not semver, but SwiftPM actually supports checking out git tags that have 'v' prefix. Modifications: - Move `TSCUtility.Verson.init(tag:)` to `Basics` for sharing - Use `Version(tag:)`, which strips away any 'v' prefix, instead of `Version(string:)`
|
@swift-ci please smoke test |
bitjammer
pushed a commit
to bitjammer/swift-package-manager
that referenced
this pull request
Jul 23, 2021
Motivation: Package versions with 'v' prefix (e.g., `v1.0.0`) in a collection are dropped because they are not semver, but SwiftPM actually supports checking out git tags that have 'v' prefix. Modifications: - Move `TSCUtility.Verson.init(tag:)` to `Basics` for sharing - Use `Version(tag:)`, which strips away any 'v' prefix, instead of `Version(string:)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Package versions with 'v' prefix (e.g.,
v1.0.0) in a collection are dropped because they are not semver, but SwiftPM actually supports checking out git tags that have 'v' prefix.Modifications:
TSCUtility.Verson.init(tag:)toBasicsfor sharingVersion(tag:), which strips away any 'v' prefix, instead ofVersion(string:)