[5.5] Update BuildToolTests.testBuildCompleteMessage #3498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The build output on Linux has changed. Causing self hosted Linux test to fail ([example](https://ci.swift.org/job/swift-package-manager-self-hosted-Linux-smoke-test/2051/)): ``` 21:29:49 Test Case 'BuildToolTests.testBuildCompleteMessage' started at 2021-05-13 04:29:06.495 21:29:49 /home/buildnode/jenkins/workspace/swift-package-manager-self-hosted-Linux-smoke-test/branch-main/swiftpm/Tests/CommandsTests/BuildToolTests.swift:256: error: BuildToolTests.testBuildCompleteMessage : XCTAssertTrue failed - [1/4] Compiling Bar Bar.swift 21:29:49 [3/6] Merging module Bar 21:29:49 [5/7] Wrapping AST for Bar for debugging 21:29:49 [6/9] Compiling Foo Foo.swift 21:29:49 [7/9] Compiling Foo main.swift 21:29:49 [9/11] Merging module Foo 21:29:49 [11/12] Wrapping AST for Foo for debugging 21:29:49 [12/12] Linking Foo 21:29:49 [12/12] Build complete! 21:29:49 21:29:49 Test Case 'BuildToolTests.testBuildCompleteMessage' failed (5.24 seconds) ``` Modification: Update expected output in `BuildToolTests.testBuildCompleteMessage`.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
tomerd
approved these changes
May 13, 2021
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3496 for 5.5