[5.5] run trie generation thread with QOS set to background #3503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: build the trie should not interrupt other threads changes: set QOS of trie thread to background
|
@swift-ci please test |
yim-lee
approved these changes
May 18, 2021
abertelrud
approved these changes
May 18, 2021
…torage has been closed (swiftlang#3505) motivation: with trie genration now running on lower priority, a race was exposed where the operation may start after the storage already was closed changes: * in trie generation, guard on state before trying to execute a statement on the connection since it may be terminated * in SQLite storage assert state does not got back frmo disconnected -> connected to help triage such issues * adjust test to new assertion
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please smoke test linux |
|
@swift-ci please test linux |
|
@swift-ci please test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings #3502 to 5.5