[5.5][Collections] Update CLI output for 'describe' #3510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What we are displaying here are stars, not watchers, so the output should reflect that.
Motivation: The collection API implementation fetches additional package metadata via GitHub APIs but we aren't showing all of it in the CLI. Modifications: Add license and languages. Reorder line items. e.g., the updated output of `describe https://github.com/apple/swift-nio`: ``` Description: Event-driven network application framework for high performance protocol servers & clients, non-blocking. Available Versions: 2.29.0, 2.28.0, 2.27.0, 1.14.2, 1.14.1, 1.14.0 Readme: https://raw.githubusercontent.com/apple/swift-nio/main/README.md License: Apache-2.0 (https://raw.githubusercontent.com/apple/swift-nio/main/LICENSE.txt) Authors: weissi, normanmaurer, Lukasa, compnerd, glbrntt, PeterAdams-A, tomerd, tigerpixel, kevinclark, fabianfett, BasThomas, Davidde94, gwynne, helje5, ktoso, ddunbar, ianpartridge, hassila, tanner0101, 2bjake, Mordil, shekhar-rajak, adamnemecek, AndriusA, toffaletti, agnosticdev, slashmo, adtrevor, Bouke, cpriebe Stars: 6450 Languages: Ruby, Swift, DTrace, C, Dockerfile, Shell, Python ------------------------------------------------------------ Latest Version: 2.29.0 Tools Version: 5.0.0 Package Name: swift-nio Modules: _NIO1APIShims, NIO, _NIOConcurrency, NIOFoundationCompat, NIOConcurrencyHelpers, NIOHTTP1, NIOTLS, NIOWebSocket, NIOTestUtils Products: NIO, _NIO1APIShims, _NIOConcurrency, NIOTLS, NIOHTTP1, NIOConcurrencyHelpers, NIOFoundationCompat, NIOWebSocket, NIOTestUtils ``` rdar://77533967
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
tomerd
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #3439 and #3509 for 5.5
rdar://77533967