Skip to content

[5.5] Avoid warnings when using SDKs without a Concurrency module #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

neonichu
Copy link
Contributor

5.5 cherry-pick of #3517

When mixing a newer compiler which does the implicit concurrency import with an older SDK that doesn't have a Concurrency module, manifest compilation is emitting warnings right now. This adds an extra flag to disable the implicit import if the flag is supported by the compiler in use.

rdar://78032108

(cherry picked from commit b0e0388)
@neonichu
Copy link
Contributor Author

@swift-ci please test

@tomerd tomerd added the 5.5 label May 29, 2021
@neonichu
Copy link
Contributor Author

neonichu commented Jun 1, 2021

Looks like #3398 is not in 5.5, but probably should be.

@neonichu
Copy link
Contributor Author

neonichu commented Jun 1, 2021

If we end up cherry-picking this, we'll also need #3521

@neonichu
Copy link
Contributor Author

Both required PRs have been cherry-picked now.

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu neonichu merged commit 441f465 into release/5.5 Jun 22, 2021
@neonichu neonichu deleted the rdar-78032108 branch June 22, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants