Skip to content

[Collections] Support multiple cert pinning configs per domain #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2021
Merged

[Collections] Support multiple cert pinning configs per domain #3530

merged 1 commit into from
Jun 15, 2021

Conversation

yim-lee
Copy link
Contributor

@yim-lee yim-lee commented Jun 5, 2021

No description provided.

@yim-lee
Copy link
Contributor Author

yim-lee commented Jun 5, 2021

@swift-ci please smoke test

@yim-lee
Copy link
Contributor Author

yim-lee commented Jun 7, 2021

@swift-ci please smoke test macOS

@tomerd
Copy link
Contributor

tomerd commented Jun 7, 2021

@swift-ci please smoke test macOS

@tomerd
Copy link
Contributor

tomerd commented Jun 7, 2021 

23:21:40 Undefined symbols for architecture x86_64:
23:21:40   "swift::swift51override_conformsToSwiftProtocol(swift::TargetMetadata<swift::InProcess> const*, swift::TargetProtocolDescriptor<swift::InProcess> const*, __swift::__runtime::llvm::StringRef, swift::TargetProtocolConformanceDescriptor<swift::InProcess> const* (*)(swift::TargetMetadata<swift::InProcess> const*, swift::TargetProtocolDescriptor<swift::InProcess> const*, __swift::__runtime::llvm::StringRef))", referenced from:
23:21:40       _Swift50Overrides in libswiftCompatibility50.a(Overrides.cpp.o)
23:21:40 ld: symbol(s) not found for architecture x86_64
23:21:40 
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@shahmishal CI infra issues?

@shahmishal
Copy link
Member

Can please share link to the failure?

@yim-lee
Copy link
Contributor Author

yim-lee commented Jun 7, 2021

@shahmishal https://ci.swift.org/job/swift-package-manager-PR-macos-smoke-test/3244/console

@shahmishal
Copy link
Member

Sounds like it's flakiness, we should file a bug (bugs.swift.org).

@yim-lee yim-lee force-pushed the multi-cert-policies branch from 30f483c to 166e17f Compare June 14, 2021 21:56
@yim-lee
Copy link
Contributor Author

yim-lee commented Jun 14, 2021

@swift-ci please smoke test

@yim-lee yim-lee merged commit 73c47c0 into swiftlang:main Jun 15, 2021
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Jun 15, 2021
@yim-lee
[Collections] Support multiple cert pinning configs per domain (swift…
37bb987 
…lang#3530)
@yim-lee yim-lee mentioned this pull request Jun 15, 2021
Merged
yim-lee added a commit that referenced this pull request Jun 15, 2021
@yim-lee
[Collections] Support multiple cert pinning configs per domain (#3530) (
7e2123f 
#3555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@friedbunny friedbunny Awaiting requested review from friedbunny

@neonichu neonichu Awaiting requested review from neonichu

Assignees

@yim-lee yim-lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yim-lee @tomerd @shahmishal