-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Incorporate SE-0292 feedback into RegistryDraft (Third Review) #3541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please smoke test |
and redirect to a hosted package archive if one is available. | ||
|
||
```http | ||
HTTP/1.1 303 See Other | ||
Content-Version: 1 | ||
Content-Length: 2048 | ||
Digest: sha-256=a2ac54cf25fbc1ad0028f03f0aa4b96833b83bb05a14e510892bb27dea4dc812 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattt @robertlacroix @yim-lee and myself discussed this more, and I think @robertlacroix preference is for this to be part of the metadata as he originally proposed. any strong reason why we should not move it there?
another good observation @robertlacroix made after discussing the redirecting proxies is that all APIs should support 30x return code to signal the redirect. any reason why we should not make this explicit in the spec?
Package contents are immutable
089000d
to
86595fb
Compare
@mattt is this read to be merged? also should this be renamed given the proposal acceptance? |
@swift-ci Please smoke test |
This PR includes the following changes to the draft registry specification in response to feedback for SE-0292.
Etag
headers from example responses