Skip to content

Incorporate SE-0292 feedback into RegistryDraft (Third Review) #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 25, 2021

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Jun 9, 2021

This PR includes the following changes to the draft registry specification in response to feedback for SE-0292.

  • Change "A client SHOULD verify the integrity of a downloaded source archive" to "A client MUST verify the integrity of a downloaded source archive”
  • Remove clause about registry servers that index but don't host source archives
  • Replace existing uses of "SHALL" to "MUST", which is an equivalent, stylistic variant
  • Remove unnecessary Etag headers from example responses
  • Update OpenAPI specification to add 3XX response
  • Update OpenAPI specification to add operationId (useful for code generation tools)

This section was added at the request of Apple.
@mattt
Copy link
Contributor Author

mattt commented Jun 10, 2021

@swift-ci Please smoke test

and redirect to a hosted package archive if one is available.

```http
HTTP/1.1 303 See Other
Content-Version: 1
Content-Length: 2048
Digest: sha-256=a2ac54cf25fbc1ad0028f03f0aa4b96833b83bb05a14e510892bb27dea4dc812
Copy link
Contributor

@tomerd tomerd Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattt @robertlacroix @yim-lee and myself discussed this more, and I think @robertlacroix preference is for this to be part of the metadata as he originally proposed. any strong reason why we should not move it there?

another good observation @robertlacroix made after discussing the redirecting proxies is that all APIs should support 30x return code to signal the redirect. any reason why we should not make this explicit in the spec?

@tomerd tomerd self-assigned this Jun 14, 2021
@mattt mattt force-pushed the se-0292-r3-updates branch from 089000d to 86595fb Compare June 22, 2021 19:26
@tomerd
Copy link
Contributor

tomerd commented Jun 23, 2021

@mattt is this read to be merged? also should this be renamed given the proposal acceptance?

@mattt
Copy link
Contributor Author

mattt commented Jun 23, 2021

@tomerd Yes, this is ready to be merged. Good call on renaming. I just pushed that with 8185efe.

@mattt
Copy link
Contributor Author

mattt commented Jun 23, 2021

@swift-ci Please smoke test

@tomerd tomerd merged commit e3ea6ed into swiftlang:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants