Skip to content

Fix pluralization of 'package-collection refresh' text #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

friedbunny
Copy link
Member

An exceedingly minor grammar fix: conditionally pluralize the package-collection refresh response based on the number of collections that were refreshed.

Motivation:

Use correct grammar in user-facing messages.

Modifications:

Changed the output of package-collection refresh to say "Refreshed n configured package collection[s]." instead of always pluralizing "collections".

Result:

If only one collection is refreshed, the output of this command will now say "collection" instead of "collections".

An exceedingly minor grammar fix: conditionally pluralize the `package-collection refresh` response based on the number of collections that were refreshed.
@friedbunny friedbunny added the ready Author believes the PR is ready to be merged & any feedback has been addressed label Jun 10, 2021
@friedbunny friedbunny self-assigned this Jun 10, 2021
@friedbunny
Copy link
Member Author

@swift-ci please smoke test.

@friedbunny friedbunny merged commit 248636a into swiftlang:main Jun 11, 2021
@friedbunny friedbunny deleted the pluralize-refresh-collection-text branch June 11, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Author believes the PR is ready to be merged & any feedback has been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants