[Collections] 'describe' package matching is too loose #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: rdar://79069839 To distinguish between package vs. collection URL, we first search for it as if it were a package URL. The package search, however, is done using `PackageIdentity` and not the actual URL itself. The problem with identity is that it only uses the last URL path component, so `bar/foo` and `baz/foo` would end up with the same identity `foo`. Modifications: Update `findPackage` to allow multiple results since a package identity (the way it is) can be associated with multiple repository URLs. Caller of `findPackage` should then filter out packages by repository URL if needed.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
Jun 10, 2021
tomerd
approved these changes
Jun 10, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Jun 11, 2021
* [Collections] 'describe' package matching is too loose Motivation: rdar://79069839 To distinguish between package vs. collection URL, we first search for it as if it were a package URL. The package search, however, is done using `PackageIdentity` and not the actual URL itself. The problem with identity is that it only uses the last URL path component, so `bar/foo` and `baz/foo` would end up with the same identity `foo`. Modifications: Update `findPackage` to allow multiple results since a package identity (the way it is) can be associated with multiple repository URLs. Caller of `findPackage` should then filter out packages by repository URL if needed.
yim-lee
added a commit
that referenced
this pull request
Jun 14, 2021
* [Collections] 'describe' package matching is too loose Motivation: rdar://79069839 To distinguish between package vs. collection URL, we first search for it as if it were a package URL. The package search, however, is done using `PackageIdentity` and not the actual URL itself. The problem with identity is that it only uses the last URL path component, so `bar/foo` and `baz/foo` would end up with the same identity `foo`. Modifications: Update `findPackage` to allow multiple results since a package identity (the way it is) can be associated with multiple repository URLs. Caller of `findPackage` should then filter out packages by repository URL if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
rdar://79069839
To distinguish between package vs. collection URL, we first search for it as if it were a package URL. The package search, however, is done using
PackageIdentityand not the actual URL itself. The problem with identity is that it only uses the last URL path component, sobar/fooandbaz/foowould end up with the same identityfoo.Modifications:
Update
findPackageto allow multiple results since a package identity (the way it is) can be associated with multiple repository URLs. Caller offindPackageshould then filter out packages by repository URL if needed.