SwiftPM complains about @main in non main.swift file when integrated driver is not enabled #3546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
force-pushed
the
eng/at-main-in-exec-doesnt-always-work
branch
from
a387251 to
a830d30
Compare
…driver is not enabled One of several different code paths in BuildPlan.swift are taken depending on whether the integrated Swift driver is enabled, whether explicit modules are enabled, etc. In the non-integrated-driver case, the code path for adding a `-parse-as-library` when necessary wasn't taken. This moves that code to a more central place, and extends a unit test to test both single and multiple file Swift targets, which seems to trigger the difference in code paths. rdar://78080245
abertelrud
force-pushed
the
eng/at-main-in-exec-doesnt-always-work
branch
from
a830d30 to
da3d6d3
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Jun 14, 2021
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Jun 26, 2021
…driver is not enabled (swiftlang#3546) One of several different code paths in BuildPlan.swift are taken depending on whether the integrated Swift driver is enabled, whether explicit modules are enabled, etc. In the non-integrated-driver case, the code path for adding a `-parse-as-library` when necessary wasn't taken. This moves that code to a more central place, and extends a unit test to test both single and multiple file Swift targets, which seems to trigger the difference in code paths. rdar://78080245 (cherry picked from commit e84fd1c)
abertelrud
added a commit
that referenced
this pull request
Jul 6, 2021
…driver is not enabled (#3546) (#3575) One of several different code paths in BuildPlan.swift are taken depending on whether the integrated Swift driver is enabled, whether explicit modules are enabled, etc. In the non-integrated-driver case, the code path for adding a `-parse-as-library` when necessary wasn't taken. This moves that code to a more central place, and extends a unit test to test both single and multiple file Swift targets, which seems to trigger the difference in code paths. rdar://78080245 (cherry picked from commit e84fd1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of several different code paths in BuildPlan.swift are taken depending on whether the integrated Swift driver is enabled, whether explicit modules are enabled, whether there is a single source file in the module, etc.
In the non-integrated-driver case, the code path for adding a
-parse-as-librarywhen necessary wasn't taken. This moves that code to a more central place, and extends a unit test to test both single and multiple file Swift targets, which seems to trigger the difference in code paths.Separately, there should be a JIRA to eliminate the code duplication in BuildPlan.swift, because it leads to this kind of bug.
rdar://78080245