Skip to content

[5.5] Avoid calling supportedFrontendFlags on Windows #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

[5.5] Avoid calling supportedFrontendFlags on Windows #3563

merged 1 commit into from
Jun 22, 2021

Conversation

neonichu
Copy link
Contributor

5.5 cherry-pick of #3521

@neonichu
Avoid calling supportedFrontendFlags on Windows
349e2d6 
The new driver does not support Windows, yet, so the check for `supportedFrontendFlags` needs to be conditional to non-Windows.

(cherry picked from commit ddb749a)
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author 

13:40:01 Cloning 'cmark'
13:40:01 /Users/buildnode/jenkins/workspace/swift-package-manager-PR-macos
13:40:01 Cloning into 'cmark'...
13:40:01 ssh: connect to host github.com port 22: Operation timed out
13:40:01 fatal: Could not read from remote repository.
13:40:01 
13:40:01 Please make sure you have the correct access rights
13:40:01 and the repository exists.

Looks like an intermittent issue.

@neonichu
Copy link
Contributor Author

@swift-ci please test

@tomerd
Copy link
Contributor

tomerd commented Jun 21, 2021

@swift-ci please smoke test

@tomerd tomerd added the 5.5 label Jun 21, 2021
@tomerd
Copy link
Contributor

tomerd commented Jun 21, 2021

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

Looks like the macOS job failed for intermittent infra reasons:

10:43:58 Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- [email protected]:apple/swift-continuous-integration.git +refs/heads/:refs/remotes/origin/" returned status code 128:
10:43:58 stdout:
10:43:58 stderr: ssh: connect to host github.com port 22: Operation timed out
10:43:58 fatal: Could not read from remote repository.

@neonichu
Copy link
Contributor Author

@swift-ci please test macOS

@tomerd
Copy link
Contributor

tomerd commented Jun 21, 2021

@swift-ci please smoke test macOS

@neonichu
Copy link
Contributor Author

Looks as if the GH connection continues to be problematic:

12:57:02 Cloning into 'yams'...
12:57:02 ssh: connect to host github.com port 22: Operation timed out
12:57:02 fatal: Could not read from remote repository.

@neonichu
Copy link
Contributor Author

@swift-ci please test macOS

@tomerd
Copy link
Contributor

tomerd commented Jun 22, 2021

@shahmishal many (all?) of our macOS PRs are failing on accessing GirHub.com, is there a known issue?

@shahmishal
Copy link
Member

Yes, this is known issue. However, it's resolved now.

@neonichu
Copy link
Contributor Author

@swift-ci please test macOS

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test macOS

@neonichu neonichu merged commit fcd71ab into release/5.5 Jun 22, 2021
@neonichu neonichu deleted the avoid-supportedFrontendFlags-on-windows branch June 22, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud abertelrud is a code owner

@friedbunny friedbunny Awaiting requested review from friedbunny friedbunny is a code owner

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @tomerd @shahmishal