Skip to content

Do not test TSC in bootstrap #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Do not test TSC in bootstrap #3569

merged 1 commit into from
Jun 22, 2021

Conversation

neonichu
Copy link
Contributor

This seems like a leftover from the integrated TSC days. TSC has its own CI these days, so this shouldn't be necessary anymore.

Opening as a draft first, because we may need to adjust build-script to actually test TSC independently of SwiftPM's bootstrap.

This seems like a leftover from the integrated TSC days. TSC has its own CI these days, so this shouldn't be necessary anymore.
Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, at least in the current draft form.

@neonichu
Copy link
Contributor Author

Verified in swiftlang/swift-tools-support-core#226 that the TSC tests still get run, so this can be merged as is.

@neonichu neonichu marked this pull request as ready for review June 22, 2021 18:39
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu neonichu merged commit 59fa60e into main Jun 22, 2021
@neonichu neonichu deleted the dont-test-tsc-in-bootstrap branch June 22, 2021 21:55
@tomerd
Copy link
Contributor

tomerd commented Jun 22, 2021

late lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants