Skip to content

Revert "[APIDiff] Enable tests on non-Darwin" #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "[APIDiff] Enable tests on non-Darwin" #3589

wants to merge 1 commit into from

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Jul 1, 2021

Reverts #3519

@elsh
Copy link
Contributor Author

elsh commented Jul 1, 2021

We'll re-merge after test runs on latest main

tomerd
tomerd approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @elsh please reach out to the original PR author to address the issue

@elsh
Copy link
Contributor Author

elsh commented Jul 2, 2021

Reverting doesn't unblock builds, so abandoning.

@elsh elsh closed this Jul 2, 2021
@elsh elsh deleted the revert-3519-linux-api-diff branch July 2, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@friedbunny friedbunny Awaiting requested review from friedbunny

@neonichu neonichu Awaiting requested review from neonichu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsh @tomerd