[5.5] [SR-14896] swift build --build-system xcode doesn't respect SWIFT_EXEC
#3600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SWIFT_EXEC` (swiftlang#3596) When using the `xcode` build system, SwiftPM isn't passing down the result of overriding SWIFT_EXEC. The same is true for `-toolchain` and `-sdk` but this will be fixed in a different PR. Besides being incorrect and thus a generally something that should be fixed, this also affects SwiftPM CI, where the newly built compiler isn't being used when cross-compilation is active (since SwiftPM currently implements multi-architecture builds by switching build system to use xcbuild). This is the Swift 5.5 nomination of this fix. rdar://80194565 (cherry picked from commit 9aab44d)
abertelrud
added
5.5
ready
|
@swift-ci please test |
tomerd
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Swift 5.5 nomination of #3596, which fixes a problem that causes SWIFT_EXEC to not be used when the
xcodebuild system is used.The motivation for nominating this fix to 5.5 is that any SwiftPM 5.5 CI that is building packages for both x86_64 and arm64 on macOS is unintentionally using the stock compiler rather than the newly built one.