make target dependency lookup case-insensitive #3615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
changed the title
motivation: starting tools-version 5.2, SwiftPM validates the target depedenies by name but the validation is case sensitive changes: * udpate the validation to be non-case sensitive (the actual lookup is not case sensitive) * add a test rdar://80594761
|
@swift-ci please smoke test |
neonichu
approved these changes
Jul 16, 2021
tomerd
added
the
ready
abertelrud
approved these changes
Jul 16, 2021
@artemcm looks like a test you added is flaky? or maybe driver changed and this no longer works on linux? looks like another PR (#3617) failed the same way |
|
@swift-ci please smoke test linux |
1 similar comment
|
@swift-ci please smoke test linux |
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Jul 16, 2021
motivation: starting tools-version 5.2, SwiftPM validates the target depedenies by name but the validation is case sensitive changes: * udpate the validation to be non-case sensitive (the actual lookup is not case sensitive) * add a test rdar://80594761
tomerd
added a commit
that referenced
this pull request
Jul 16, 2021
motivation: starting tools-version 5.2, SwiftPM validates the target depedenies by name but the validation is case sensitive changes: * udpate the validation to be non-case sensitive (the actual lookup is not case sensitive) * add a test rdar://80594761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: starting tools-version 5.2, SwiftPM validates the target depedenies by name but the validation is case sensitive
changes: