-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[5.5] Ignore .docc files rather than emitting warnings, since it's useful to have them in packages without warnings #3616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
@swift-ci test |
The full test failure looks unrelated:
|
In fact that looks like an issue with the swift-argument-parser version being used. |
Ah yes, that is mentioned in other PRs. Running the smoke test again, since it should have been cleared up based on comments I see in other PRs. |
@swift-ci please smoke test |
@swift-ci test |
Looks like the smoke test is using swift-argument-parser 0.4.1 but swift-package-manager needs 0.4.3. But that's not a new requirement in this PR. That was added in 1a361f7 on July 8. @shahmishal or @neonichu do you know why the smoke test here used 0.4.1? Or to whom would I need to talk to get that updated? I this case I think that as long as the full test passes, we can merge, since the smoke test isn't required and the failure is a configuration and not a code issue. But it would be good to update the swift-argument-parser version that's used. |
@swift-ci please smoke test |
…eful to have them in packages without warnings Unlike other Xcode-specific file types, such as Storyboards and Asset Catalogs, the .docc bundles are not needed for correctness during the build, and should therefore not trigger warnings. rdar://78133445 (cherry picked from commit 8f9e5d3 and f39a8be)
23b6061
to
c0504e1
Compare
@swift-ci please test |
Updated with the refinement in #3620. |
This is the 5.5 nomination of #3609. Same motivation and changes as in that PR.