-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add nested PackgeIdentity.Scope
and PackageIdentity.Name
types
#3658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
This source file is part of the Swift.org open source project | ||
|
||
Copyright (c) 2021 Apple Inc. and the Swift project authors | ||
Licensed under Apache License v2.0 with Runtime Library Exception | ||
|
||
See http://swift.org/LICENSE.txt for license information | ||
See http://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
*/ | ||
|
||
import XCTest | ||
import Basics | ||
import TSCBasic | ||
import PackageModel | ||
|
||
class PackageIdentityNameTests: XCTestCase { | ||
func testValidNames() throws { | ||
XCTAssertNoThrow(try PackageIdentity.Name(validating: "LinkedList")) | ||
XCTAssertNoThrow(try PackageIdentity.Name(validating: "Linked-List")) | ||
XCTAssertNoThrow(try PackageIdentity.Name(validating: "Linked_List")) | ||
XCTAssertNoThrow(try PackageIdentity.Name(validating: "A")) | ||
XCTAssertNoThrow(try PackageIdentity.Name(validating: "1")) | ||
XCTAssertNoThrow(try PackageIdentity.Name(validating: String(repeating: "A", count: 100))) | ||
} | ||
|
||
func testInvalidNames() throws { | ||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "")) { error in | ||
XCTAssertEqual(error.localizedDescription, "The minimum length of a package name is 1 character.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: String(repeating: "a", count: 101))) { error in | ||
XCTAssertEqual(error.localizedDescription, "The maximum length of a package name is 100 characters.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "!")) { error in | ||
XCTAssertEqual(error.localizedDescription, "A package name consists of alphanumeric characters, underscores, and hyphens.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "あ")) { error in | ||
XCTAssertEqual(error.localizedDescription, "A package name consists of alphanumeric characters, underscores, and hyphens.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "🧍")) { error in | ||
XCTAssertEqual(error.localizedDescription, "A package name consists of alphanumeric characters, underscores, and hyphens.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "-a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur at the beginning of a name.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "_a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur at the beginning of a name.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "a-")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur at the end of a name.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "a_")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur at the end of a name.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "a_-a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur consecutively within a name.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "a-_a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur consecutively within a name.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "a--a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur consecutively within a name.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Name(validating: "a__a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens and underscores may not occur consecutively within a name.") | ||
} | ||
} | ||
|
||
func testNamesAreCaseInsensitive() throws { | ||
let lowercase: PackageIdentity.Name = "linkedlist" | ||
let uppercase: PackageIdentity.Name = "LINKEDLIST" | ||
|
||
XCTAssertEqual(lowercase, uppercase) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
This source file is part of the Swift.org open source project | ||
|
||
Copyright (c) 2021 Apple Inc. and the Swift project authors | ||
Licensed under Apache License v2.0 with Runtime Library Exception | ||
|
||
See http://swift.org/LICENSE.txt for license information | ||
See http://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
*/ | ||
|
||
import XCTest | ||
import Basics | ||
import TSCBasic | ||
import PackageModel | ||
|
||
class PackageIdentityScopeTests: XCTestCase { | ||
func testValidScopes() throws { | ||
XCTAssertNoThrow(try PackageIdentity.Scope(validating: "mona")) | ||
XCTAssertNoThrow(try PackageIdentity.Scope(validating: "m-o-n-a")) | ||
XCTAssertNoThrow(try PackageIdentity.Scope(validating: "a")) | ||
XCTAssertNoThrow(try PackageIdentity.Scope(validating: "1")) | ||
XCTAssertNoThrow(try PackageIdentity.Scope(validating: String(repeating: "a", count: 39))) | ||
} | ||
|
||
func testInvalidScopes() throws { | ||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: "")) { error in | ||
XCTAssertEqual(error.localizedDescription, "The minimum length of a package scope is 1 character.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: String(repeating: "a", count: 100))) { error in | ||
XCTAssertEqual(error.localizedDescription, "The maximum length of a package scope is 39 characters.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: "!")) { error in | ||
XCTAssertEqual(error.localizedDescription, "A package scope consists of alphanumeric characters and hyphens.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: "あ")) { error in | ||
XCTAssertEqual(error.localizedDescription, "A package scope consists of alphanumeric characters and hyphens.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: "🧍")) { error in | ||
XCTAssertEqual(error.localizedDescription, "A package scope consists of alphanumeric characters and hyphens.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: "-a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens may not occur at the beginning of a scope.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: "a-")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens may not occur at the end of a scope.") | ||
} | ||
|
||
XCTAssertThrowsError(try PackageIdentity.Scope(validating: "a--a")) { error in | ||
XCTAssertEqual(error.localizedDescription, "Hyphens may not occur consecutively within a scope.") | ||
} | ||
} | ||
|
||
func testScopesAreCaseInsensitive() throws { | ||
let lowercase: PackageIdentity.Scope = "mona" | ||
let uppercase: PackageIdentity.Scope = "MONA" | ||
|
||
XCTAssertEqual(lowercase, uppercase) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use regex patterns to do the validation?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but I can think of a few drawbacks to that approach:
On the plus side, a regex is a more obvious representation than string manipulation code. But with comprehensive testing, that's probably less of a concern.