[5.5] Allow a custom manifest loader to provide custom environment variables when compiling the manifest #3667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a sorted dictionary.
abertelrud
requested review from
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
…st and plugin compilation It defaults to `ProcessEnv.vars` so that there is no change in semantics unless the client code customizes the environment.
abertelrud
force-pushed
the
eng/allow-manifest-resources-to-customize-compiler-environment-5.5
branch
from
3835e39 to
9d5783e
Compare
|
@swift-ci please test |
neonichu
approved these changes
Aug 16, 2021
tomerd
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the ManifestLoaderProtocol to allow a custom manifest loader to provide custom environment variables when compiling the manifest.
Motivation:
Clients of libSwiftPM can already provide a set of custom flags to pass to the Swift compiler when compiling and linking the manifest. This extends this support to allow custom environment entries as well. There's no immediate use for this in SwiftPM itself, but it could be used in the future, and some clients need this.
Modifications:
Result:
Clients of libSwiftPM can specify environment entries. Note that this does not affect the environment that is passed when running the compiled manifest.